Fixed oop return type of DateTimeInterface::getOffset. #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Dec 22, 2020
cmb69
approved these changes
Dec 22, 2020
|
closes by commit: 260c0b8 |
cmb69
added a commit
to cmb69/php-src
that referenced
this pull request
Dec 26, 2020
php-pulls
pushed a commit
to php/php-src
that referenced
this pull request
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not return false, but zero.
https://github.com/php/php-src/blob/caa710037e663fd78f67533b29611183090068b2/ext/date/php_date.c#L3099-L3130
Note: if this fix is correct, we need to fix ext/date/php_date.stub.php.