Add a notice to spl_object_hash() return values comparison
#2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jul 28, 2023
Comment on lines
75
to
79
| Object hashes should always be strictly compared with <code>===</code> and | ||
| <code>!==</code>, because returned hashes could be a valid integer | ||
| representation like <code>0000000000000e600000000000000000</code> (which is | ||
| a valid integer representation using exponent notation). Not doing so may | ||
| lead to confusing and false comparisons. |
There was a problem hiding this comment.
Improve wording to use the name of the === operator, but also I don't know if saying this can lead to confusing comparison needs more detail if we mention (and link) to numeric strings.
Suggested change
| Object hashes should always be strictly compared with <code>===</code> and | |
| <code>!==</code>, because returned hashes could be a valid integer | |
| representation like <code>0000000000000e600000000000000000</code> (which is | |
| a valid integer representation using exponent notation). Not doing so may | |
| lead to confusing and false comparisons. | |
| Object hashes should be compared for identity with <code>===</code> and | |
| <code>!==</code>, because the returned hash could be a | |
| <link linkend="language.types.numeric-strings">numeric string</link>. | |
| For example: <literal>0000000000000e600000000000000000</literal>. |
There was a problem hiding this comment.
That's definitely better. It's updated, thanks for the suggestion!
alexandre-daubois
force-pushed
the
spl-object-hash-notice
branch
from
a4446e2 to
978dfca
Compare
|
Thank you! |
nielsdos
pushed a commit
to nielsdos/doc-en
that referenced
this pull request
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2406