Replace <literal> nodes with <constant> for constants

[phansys]

172 occurrences were replaced from <literal>([A-Za-z0-9_]+)::([A-Z0-9_\*]+)</literal> to <constant>$1::$2</constant>.

See #2306 (comment).

TODO:

• Wait for Mark up unspecific constants as replaceable #1963.

[Girgias]

Thanks for tackling this, this makes sense.

However, I'd wait a bit to check with translations as this does do some busy work for them (and as I'm being on the French translation and the constant tag does not generates links it would be nice that I can tackle more urgent stuff)

[Girgias]

It would make sense to coordinate this with #1963 also to not repeat the work multiple times.

[phansys]

Great! Let me inherit these changes here and mark the other PR in a TO-DO list in order to make the dependency explicit.

[Girgias]

Overall OK but I'm going to wait to merge this as this is a QA change.

Also it would be nice to fix the whitespaces in another PR that one can skip-revcheck as those clutter the PR.

[phansys]

Also it would be nice to fix the whitespaces in another PR that one can skip-revcheck as those clutter the PR.

Whitespace changes were reverted 👍

[Girgias]

Sorry for the delay in this, could you rebase the PR on master?

[phansys]

Rebased.

[haszi]

There are a few constants with replaceable parts that use _XXX instead of _*. Do you think it would make sense to add those to this PR?

These are the ones I've found in doc-en:

CURL_VERSION_XXX
CURLM_XXX
CURLOPT_XXX
IMAGETYPE_XXX
PNG_FILTER_XXX
SOAP_PERSISTENCE_XXX
TIDY_TAG_XXX
VT_XXX

[phansys]

I think these are missing cases @haszi. Thank you for pointing.
Let me check if I can find a consistent way to catch them and I'll update the PR.

[phansys]

The cases using the _XXX suffix were addressed.

[Girgias]

Not sure the runkit changes are appropriate, nor the Enumeration docs as those refer to inline examples, maybe using code is more appropriate but I need to have a think about this.