Skip to content

Update ext/random role attributes #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Conversation

kocsismate
Copy link
Member

Based on php/php-src#9901

@kocsismate kocsismate requested review from TimWolla and cmb69 December 11, 2022 21:10
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I eyeballed the changes and did not see anything obviously wrong and I trust you performed the changes correctly. I don't have any pending changes, so this is good to go. Thanks!

@kocsismate kocsismate merged commit 5e2031d into php:master Dec 11, 2022
@kocsismate kocsismate deleted the role-random branch December 11, 2022 21:40
kocsismate added a commit to kocsismate/doc-en that referenced this pull request Dec 11, 2022
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants