Skip to content

Document dynamic properties #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2022
Merged

Document dynamic properties #1942

merged 2 commits into from
Nov 7, 2022

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 4, 2022

Because obviously this is not documented sigh

cmb69
cmb69 reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks mostly good, besides the "access" issue.

@Girgias @cmb69
Use assign instead of access
a00acdf 
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Girgias Girgias merged commit 6e042e0 into php:master Nov 7, 2022
@Girgias Girgias deleted the dynamic-properties branch November 7, 2022 00:54
@Girgias Girgias mentioned this pull request Nov 7, 2022
Closed
@Girgias Girgias added this to the PHP 8.2 milestone Nov 12, 2022
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
@Girgias @cmb69 @claudepache
Document dynamic properties (php#1942)
3a2ad0d 
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @cmb69