Add Locale::getLanguage() and make getPrimaryLanguage() its alias #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documentation change supports the php-src pull request at php/php-src#7644
cmb69
reviewed
Dec 9, 2022
| <methodparam><type>string</type><parameter>locale</parameter></methodparam> | ||
| </methodsynopsis> | ||
| <para> | ||
| Gets the language for the input locale |
There was a problem hiding this comment.
Even though this has been copied, let's stick with basic English punctuation rules :)
Suggested change
| Gets the language for the input locale | |
| Gets the language for the input locale. |
| <term><parameter>locale</parameter></term> | ||
| <listitem> | ||
| <para> | ||
| The locale to extract the language code from |
There was a problem hiding this comment.
Suggested change
| The locale to extract the language code from | |
| The locale to extract the language code from. |
| </methodsynopsis> | ||
| <para> | ||
| Gets the primary language for the input locale | ||
| Gets the language for the input locale |
There was a problem hiding this comment.
Since this line is modified anyway:
Suggested change
| Gets the language for the input locale | |
| Gets the language for the input locale. |
| </para> | ||
| <note> | ||
| <para> | ||
| <methodname>Locale::getPrimaryLanguage</methodname> is an alias of <methodname>Locale::getLanguage</methodname>. |
There was a problem hiding this comment.
This is only the case as of PHP 8.2.0, so:
Suggested change
| <methodname>Locale::getPrimaryLanguage</methodname> is an alias of <methodname>Locale::getLanguage</methodname>. | |
| As of PHP 8.2.0, <methodname>Locale::getPrimaryLanguage</methodname> | |
| is an alias of <methodname>Locale::getLanguage</methodname>. |
| <listitem> | ||
| <para> | ||
| The locale to extract the primary language code from | ||
| The locale to extract the language code from |
There was a problem hiding this comment.
Suggested change
| The locale to extract the language code from | |
| The locale to extract the language code from. |
| <para> | ||
| &style.oop; | ||
| </para> | ||
| <methodsynopsis role="oop"> |
There was a problem hiding this comment.
@kocsismate, do we want to fix the role right away?
cmb69
requested changes
Dec 9, 2022
|
@ramsey If the php-src PR was closed without merging, is this documentation PR still relevant? |
|
This PR can be closed, since the other was closed without merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation change supports the php-src pull request at php/php-src#7644