Fix PHP 8.1 compatibility #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
reviewed
Sep 26, 2021
williamdes
approved these changes
Sep 26, 2021
driesvints
approved these changes
Sep 29, 2021
Contributor
|
Hey @OndraM, any chance we can get this merged and tagged? That way we can get fruitcake/laravel-cors#544 merged and offer full support for PHP 8.1 in Laravel. |
OndraM
requested changes
Oct 11, 2021
Collaborator
|
@kylekatarnls Could you please rebase the branch against current |
OndraM
requested changes
Oct 13, 2021
Co-authored-by: Ondřej Machulda <ondrej.machulda@gmail.com>
OndraM
approved these changes
Oct 14, 2021
Collaborator
|
Merged and will be released soon. Thanks @kylekatarnls! 💯 |
OndraM
added a commit
to OndraM/php-webdriver
that referenced
this pull request
Nov 8, 2021
* Fix PHP 8.1 compatibility Co-authored-by: Ondřej Machulda <ondrej.machulda@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.