Prepare 1.1.0 release #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@php-translation/members could we move forward? |
|
LGTM, but I'm not very familiar with release process and side effects on other packages of php-translation. But I want to learn 😉 |
|
I don't think there is a specific release process but I may be wrong (ping @Nyholm?). |
Nyholm
approved these changes
Dec 5, 2019
|
I've reviewed the diff. The idea of each package is that they live their own life. So the release process here is not different to any package. If we just follow Semver then Composer will sort out version issues. @odolbeau Let's release this and make sure the bundle supports sf 5. =) |
rvanlaak
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.