Skip to content

bug: js error use own object extends HTMLElement #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

gimler
Copy link
Contributor

@gimler gimler commented Sep 10, 2023

It seams that it is not allowed to use HTMLElement directly as constructor.

fix #409

  • remove old symfony 4 compatiblity layer (lib has min. 5.3 see composer.json)
  • fix cs

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it fixes the problem for you - sounds good to me.

Could you also fix failed (unrelated) code styles here, please?

@gimler
Copy link
Contributor Author

gimler commented Sep 11, 2023

@bocharsky-bw all green. can you also please make a new release?

@bocharsky-bw bocharsky-bw merged commit cdeaa4d into php-translation:master Sep 12, 2023
@bocharsky-bw
Copy link
Member

Thank you for this fix! I created a new release: https://github.com/php-translation/symfony-bundle/releases/tag/0.14.1

@gimler gimler deleted the patch-1 branch March 27, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal constructor in editInPlace.js at lines 11 and 19
2 participants