Add Yandex translator support #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocharsky-bw
commented
Dec 13, 2017
| @@ -182,7 +182,7 @@ private function addAutoTranslateNode(ArrayNodeDefinition $root) | |||
| ->arrayNode('fallback_translation') | |||
| ->canBeEnabled() | |||
| ->children() | |||
| ->enumNode('service')->values(['google', 'bing'])->defaultValue('google')->end() | |||
| ->enumNode('service')->values(['google', 'yandex', 'bing'])->defaultValue('google')->end() | |||
There was a problem hiding this comment.
Actually, we do not have bind support if I'm not wrong, so maybe remove it from this list for now until php-translation/translator#1 will be implemented?
There was a problem hiding this comment.
You are correct. I just wanted have more than one value when I first write this enum (maybe it was a requirement?).
Anyhow. We should remove bing and use yandex and google only.
Nyholm
reviewed
Dec 16, 2017
| @@ -182,7 +182,7 @@ private function addAutoTranslateNode(ArrayNodeDefinition $root) | |||
| ->arrayNode('fallback_translation') | |||
| ->canBeEnabled() | |||
| ->children() | |||
| ->enumNode('service')->values(['google', 'bing'])->defaultValue('google')->end() | |||
| ->enumNode('service')->values(['google', 'yandex', 'bing'])->defaultValue('google')->end() | |||
There was a problem hiding this comment.
You are correct. I just wanted have more than one value when I first write this enum (maybe it was a requirement?).
Anyhow. We should remove bing and use yandex and google only.
|
You have done a great job on this org! Really appreciated! |
|
Glad to help ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see Translator already supports Yandex: php-translation/translator#7