Skip to content

Profiler renders incorrectly if checkboxes are disabled #496

Closed
@althaus

Description

@althaus

Hi,

I've found an issue in the profiler template:

https://github.com/php-translation/symfony-bundle/blob/master/Resources/views/SymfonyProfiler/translation.html.twig#L68

            {% if withCheckbox %}
                <th>
                    <input type="checkbox" id="check-all-control" onchange="toggleCheckAll(this)" checked="checked">
                </th>
            {% endif %}

vs

                <td>
                    {% if withCheckbox %}
                        <input type="checkbox" name="translationKey" value="{{ key }}" checked="checked" class="translation-key-checkbox">
                    {% endif %}
                </td>

https://github.com/php-translation/symfony-bundle/blob/master/Resources/views/SymfonyProfiler/translation.html.twig#L84

So without checkbox activated, it renders no header but an empty cell. This leads to a misaligned table:

grafik

Kind regards
Matthias

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions