Skip to content

Conversation

notflip
Copy link

@notflip notflip commented Mar 9, 2015

I changed the way Laravel loads it's config file, as well as the readme.md on how to achieve it.
Also changed how config files get loaded.

@MarkRedeman
Copy link
Contributor

This would break compatibility with Laravel 4 users.
You could either increase the version number of this package, or, if you'd rather not have any BC breaks, you could use different Service Providers for the Laravel 5 version.
For example a TmdbServiceProvider.php that works for Laravel 4 and a FiveTmdbServiceProvider.php provider that works for Laravel 5.

@wtfzdotnet
Copy link
Member

I'd prefer naming conventions such as Legacy* in this case :), new versions are first class citizens

@MarkRedeman MarkRedeman closed this Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants