[travis] Make tests green #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yukoff
commented
Sep 10, 2017
yukoff
commented
- Use vendor phpunit instead of global
- Add --prefer-lowest to matrix
- Add php 7.1 and nightly to matrix
yukoff
force-pushed
the
feature/make-tests-green
branch
4 times, most recently
from
8aece98 to
4c39553
Compare
* Use vendor phpunit instead of global * Add --prefer-lowest to matrix * Add php 7.1 and nightly to matrix
yukoff
force-pushed
the
feature/make-tests-green
branch
from
4c39553 to
dc7e0dd
Compare
Laravel dispatcher should be either Illuminate\Contracts\Events\Dispatcher or Illuminate\Events\Dispatcher, however only the latter has fire() method, which in turn just a wrapper for dispatch() Using fire() inplace with contract tests are failing with exceptions: 1. Tmdb\Laravel\Adapters\Tests\EventDispatcherTestLaravel5::it_dispatches_events_through_both_laravel_and_symfony Prophecy\Exception\Doubler\MethodNotFoundException: Method `Double\Dispatcher\P25::fire()` is not defined. 2. Tmdb\Laravel\Adapters\Tests\EventDispatcherTestLaravel5::it_returns_the_event_returned_by_the_symfony_dispatcher Prophecy\Exception\Doubler\MethodNotFoundException: Method `Double\Dispatcher\P27::fire()` not found.
yukoff
force-pushed
the
feature/make-tests-green
branch
from
dc7e0dd to
2442690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.