Skip to content

Conversation

wtfzdotnet
Copy link
Member

@wtfzdotnet wtfzdotnet commented Dec 29, 2020

WIP

Continuation of #222

  • Finish refactor of HttpClient and relevant classes
  • Finish refactor of Client and relevant classes
  • Fix performance issues related to hydration of objects through events
  • Implement caching
  • Implement logging
  • Reimplement exceptions
  • Review todo's
  • Todo list
    • All examples containg SessionToken are broken, needs fixing.
    • Review all examples, do quick fixes and identify stuff that needs a second look before releasing 4.0.
    • AvatarFactory seems to have a bug, monkey patched this for unit tests to work, but needs a second look.
    • Examples
      • A couple of examples still have errors, need to check these out.
    • Tests
      • GenreRepositoryTest
      • AuthenticationTest
      • GenresTest
      • MoviesTest
      • PeopleFactoryTest
      • TvFactoryTest
      • AuthenticationRepositoryTest
  • Deprecate and remove while we can
  • Upgrade readme
  • Documentation update
  • Prepare release
  • Release 4.0.0-alpha

@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (4.0@972553c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             4.0     #225   +/-   ##
======================================
  Coverage       ?   83.82%           
  Complexity     ?     2079           
======================================
  Files          ?      194           
  Lines          ?     5261           
  Branches       ?        0           
======================================
  Hits           ?     4410           
  Misses         ?      851           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972553c...846db82. Read the comment docs.

…formed some regex magic to add the new setup-client.php file within the examples.
- Fixed most examples with a setup file that is use-able out of the box
- Removed default implementation of hydration events, only use these when you really need them.
  - Causes a significant overhead, as such it has been disabled by default
  - Now allows only certain models to be hydrated through this construction.
- Updated README accordingly
@wtfzdotnet
Copy link
Member Author

wtfzdotnet commented Dec 31, 2020

Who would have thought the hydration events had such a major impact...

Test suites dropped from ~710ms to 470ms.

@wtfzdotnet wtfzdotnet added this to the 4.0 milestone Jan 1, 2021
@wtfzdotnet wtfzdotnet self-assigned this Jan 1, 2021
@wtfzdotnet wtfzdotnet added the WIP label Jan 1, 2021
@wtfzdotnet wtfzdotnet marked this pull request as ready for review January 4, 2021 20:05
@wtfzdotnet wtfzdotnet merged commit a06a985 into 4.0 Jan 4, 2021
@wtfzdotnet wtfzdotnet deleted the release/4.0.0 branch January 4, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guzzle 7

2 participants