Possible fix for #917 #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I've looked into this and there is a super simple fix for this: Then there are no constraint problems 🎉 @jacklul I've added a commit to this PR with just that tiny change, please test it to see if it also works for you. |
noplanman
force-pushed
the
fix_message_cleanup
branch
from
29b31c8 to
112ef4b
Compare
noplanman
force-pushed
the
fix_message_cleanup
branch
from
242fd58 to
e568ae5
Compare
noplanman
force-pushed
the
fix_message_cleanup
branch
from
e568ae5 to
82f3b63
Compare
|
@jacklul Have reverted my changes and left yours, which does the trick 😉 Good to merge? |
noplanman
approved these changes
Mar 22, 2019
|
Actually I think the subquery is not required and will only impact performance, works on my end! |
|
@jacklul Doesn't work for me, I get this: |
jacklul
force-pushed
the
fix_message_cleanup
branch
from
47b4c01 to
82f3b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent constrain errors, one of side effects observed is that some messages might not get deleted in the first run. #917
Usage of two additional nested subqueries is extremely heavy here though... not sure if doing one select query and then using PHP to select ids to remove wouldn't be a lighter solution here.
PS. telegram_update query was broken because of this missing
AND updated_at < \'%1$s\'statement forchattable - it didn't clean the table until I added that - @noplanman ?