Skip to content

Conversation

@alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jul 16, 2024

This should add support for the latest symfony and latest doctrine collections version.

It also updates dev dependencies to PHPUnit 11 and also tests PHP 8.4.

Comment on lines +87 to +88
$this->taskExecutionRepository->save($executions[0])->willReturnArgument(0)->shouldBeCalledTimes(3);
$this->taskExecutionRepository->save($executions[1])->willReturnArgument(0)->shouldBeCalledTimes(3);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing since: #47

Comment on lines +121 to +122
$this->taskExecutionRepository->save($executions[0])->willReturnArgument(0)->shouldBeCalledTimes(3);
$this->taskExecutionRepository->save($executions[1])->willReturnArgument(0)->shouldBeCalledTimes(3);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing since: #47

- php-version: '8.3'
coverage: 'true'
- php-version: '8.4'
composer-flags: '--ignore-platform-reqs'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed as soon as prophecy supports 8.4 officially: https://github.com/phpspec/prophecy/blob/f9e07be0992e7bf1cad210829055b99318df142f/composer.json#L21 but mostly it takes some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants