Add symfony 6 comptability #54
Conversation
Prokyonn
force-pushed
the
enhancement/symfony-6
branch
from
a03497b to
e870f1f
Compare
Prokyonn
force-pushed
the
enhancement/symfony-6
branch
2 times, most recently
from
41ece89 to
a9a00c3
Compare
Prokyonn
force-pushed
the
enhancement/symfony-6
branch
from
a9a00c3 to
50b894e
Compare
| @@ -124,7 +128,11 @@ public function testExecuteWithFail() | |||
| $this->assertEquals($intervalTask->getWorkload(), $task->getWorkload()); | |||
| $this->assertLessThanOrEqual($intervalTask->getFirstExecution(), $task->getFirstExecution()); | |||
| $this->assertLessThanOrEqual($intervalTask->getLastExecution(), $task->getLastExecution()); | |||
| $this->assertEquals($intervalTask->getInterval(), $task->getInterval()); | |||
There was a problem hiding this comment.
asserting equals between the interval object resulted in an error: https://github.com/php-task/TaskBundle/runs/7495173211?check_suite_focus=true
honestly I've no idea why this happens in the CI, locally everything works as expected 😅
but I guess the new additional lines test the same thing and it is working now also in the CI :)
There was a problem hiding this comment.
@Prokyonn is there a __toString method? i would compare at least this
There was a problem hiding this comment.
@wachterjohannes https://github.com/dragonmantank/cron-expression/blob/master/src/Cron/CronExpression.php#L384-L387 yes, but this is already implicitly tested in line 132:
$this->assertEquals($intervalTask->getInterval()->getExpression(), $task->getInterval()->getExpression());
There was a problem hiding this comment.
OK then all right - should we tag the library first?
There was a problem hiding this comment.
yeah makes sense to add a version instead of the dev branch before merging :)
Prokyonn
changed the title
composer.json
Outdated
| "symfony/process": "^2.8 || ^3.4 || ^4.0 || ^5.0", | ||
| "doctrine/orm": "^2.5" | ||
| "php": "^8.0 || ^8.1", | ||
| "php-task/php-task": "dev-master as 2.0", |
There was a problem hiding this comment.
@Prokyonn please update the composer.json https://github.com/php-task/php-task/releases/tag/2.0.0
There was a problem hiding this comment.
@wachterjohannes done
No description provided.