-
Notifications
You must be signed in to change notification settings - Fork 8
Implemented system-tasks #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
33b0f63
to
1f80722
Compare
91b0c04
to
e0c4b52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade for the database is missing
Old system tasks are not removed from executions. |
1586d92
to
08c10c7
Compare
->arrayNode('system_tasks') | ||
->prototype('array') | ||
->children() | ||
->booleanNode('enabled')->defaultTrue()->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't false
be a better default? Or does it still work if the three settings below are not set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a prototype which can be extended. when i add a system-task it should be enabled by default. if i want to keep the config but want to disable it you can set the enabled flag.
If the old tasks continue to work as until now, and no configuration has to be adapted (I already commented a line which is suspicious) I don't see how that should break Sulu. |
@danrot problem is that you have to update the schema of the table |
e247051
to
ae33ecb
Compare
ae33ecb
to
8ab1c59
Compare
Looks like you are merging it into develop, so it will only come with the next minor release? Should be fine in my opinion. |
@danrot yes it will go into 1.1.0 |
7940bfe
to
ac8a772
Compare
ac8a772
to
790baf4
Compare
This PR introduces the feature of system tasks. You can now configure predefined tasks in you config tree:
Related PR: php-task/php-task#31 php-task/docs#4
TODO