Skip to content

Generate array shapes for PHPStan #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Dec 3, 2021
Merged

Generate array shapes for PHPStan #21

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
29e97f7
Add a custom node visitor which generates array shapes for parameters.
johnbillion Nov 29, 2021
30c59aa
Don't generate an array shape if any of its elements keys are unknown.
johnbillion Nov 29, 2021
dede957
Handle more wonky spacing.
johnbillion Nov 30, 2021
67bba4c
Make this easier to read.
johnbillion Nov 30, 2021
555e8f6
PHPStan doesn't allow typed shaped arrays.
johnbillion Nov 30, 2021
722310f
Don't use an array shape if it's not an array.
johnbillion Nov 30, 2021
fee75f8
Push the array type to the end of the list.
johnbillion Nov 30, 2021
fb0d9f1
Ignore broken parameter references.
johnbillion Nov 30, 2021
49b5e0e
Coding standards.
johnbillion Nov 30, 2021
bb213a1
Reuse the docblock factory.
johnbillion Nov 30, 2021
e557e53
PHPStan config.
johnbillion Nov 30, 2021
b598e90
Docs.
johnbillion Dec 1, 2021
14489d5
Fix these.
johnbillion Dec 1, 2021
04206ad
Split this up a bit.
johnbillion Dec 2, 2021
b78ffe3
Prepare this to be applicable to any tag type.
johnbillion Dec 2, 2021
29fc893
More splitting up.
johnbillion Dec 2, 2021
c7698d2
Generate `@phpstan-return` tags too.
johnbillion Dec 2, 2021
adfcbcb
Remove some duplication.
johnbillion Dec 2, 2021
1066744
This isn't needed.
johnbillion Dec 2, 2021
7dfacf5
Naming.
johnbillion Dec 2, 2021
8dff3b0
Add an explanation for this.
johnbillion Dec 2, 2021
c7f4c6e
Update stubs.
johnbillion Dec 2, 2021
6368f64
Merge branch 'master' into phpstan-param-arrays
johnbillion Dec 2, 2021
62a1d4b
Update the stubs.
johnbillion Dec 2, 2021
5f82c9e
Bump the stubs generator.
johnbillion Dec 2, 2021
88fa57e
Make this more accurate.
johnbillion Dec 2, 2021
b394261
Update the stubs again.
johnbillion Dec 2, 2021
d7780d1
Elements in return arrays generally aren't optional.
johnbillion Dec 2, 2021
4ddacfb
Updated stubs.
johnbillion Dec 2, 2021
57a18b1
PHP 7.3 syntax.
johnbillion Dec 2, 2021
99f196b
Remove temporary PHPStan for testing.
johnbillion Dec 2, 2021
294da8d
More guard conditions.
johnbillion Dec 2, 2021
f6c7d9d
Add PHPStan for our lovely new code.
johnbillion Dec 2, 2021
f92b002
Fix everything.
johnbillion Dec 2, 2021
3003673
Update visitor.php
johnbillion Dec 3, 2021
547148f
Update visitor.php
johnbillion Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle more wonky spacing.
  • Loading branch information
@johnbillion
johnbillion committed Nov 30, 2021
commit dede957f19a93e2a62fb090458ba1c2c19a1282b
2 changes: 1 addition & 1 deletion visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private function addArrayHashNotation(Doc $docComment): ?Doc
$elements = [];

foreach ($types as $type) {
$parts = preg_split('#\s+#', $type);
$parts = preg_split('#\s+#', trim($type));

if (strpos($parts[1], '...$') !== false) {
return null;
Expand Down