wp_trigger_error has a wrong @phpstan-param

[jcvignoli]

wp_trigger_error() functions reads as follows:

    /**
     * Generates a user-level error/warning/notice/deprecation message.
     *
     * Generates the message when `WP_DEBUG` is true.
     *
     * @since 6.4.0
     *
     * @param string $function_name The function that triggered the error.
     * @param string $message       The message explaining the error.
     *                              The message can contain allowed HTML 'a' (with href), 'code',
     *                              'br', 'em', and 'strong' tags and http or https protocols.
     *                              If it contains other HTML tags or protocols, the message should be escaped
     *                              before passing to this function to avoid being stripped {@see wp_kses()}.
     * @param int    $error_level   Optional. The designated error type for this error.
     *                              Only works with E_USER family of constants. Default E_USER_NOTICE.
     * @phpstan-param callable-string $function_name
     * @phpstan-param \E_USER_ERROR|\E_USER_WARNING|\E_USER_NOTICE|\E_USER_DEPRECATED $error_level
     * @phpstan-return void
     */
    function wp_trigger_error($function_name, $message, $error_level = \E_USER_NOTICE)
    {
    }

However, according to WP documentation (or even the code), I don't see the reason for @phpstan-param callable-string $function_name. It is a string that is used as such in the function.

[szepeviktor]

Thank you for your report.

How did this type come up?

[IanDelMar]

A callable-string is indeed too restrictive for non-static methods.

class MyClass
{
    public function myMethod(): void
    {
    }
}

The method name MyClass::myMethod is not a callable-string in PHP 8.

[szepeviktor]

Thank you.

Should I close this one then?
phpstan/phpstan#12509

[szepeviktor]

The method name MyClass::myMethod is not a callable-string in PHP 8.

In PHP 7 results are all green.
https://phpstan.org/r/b2f71981-1ee2-4d09-818d-99c35d284976

Could you explain it a bit deeper?

[IanDelMar]

The method name MyClass::myMethod is not a callable-string in PHP 8.

In PHP 7 results are all green. https://phpstan.org/r/b2f71981-1ee2-4d09-818d-99c35d284976

Could you explain it a bit deeper?

In PHP 7, calling MyClass::myMethod() results in a deprecation notice (but it is callable). PHP 8 removed support for calling non-static methods statically, and calling MyClass::myMethod() now results in a fatal error.

[IanDelMar]

Thank you.

Should I close this one then? phpstan/phpstan#12509

I would argue yes. See #270 (comment)

[szepeviktor]

The ability to call non-static methods statically has been removed. Thus is_callable() will fail when checking for a non-static method with a classname (must check with an object instance).

https://www.php.net/manual/en/migration80.incompatible.php

[szepeviktor]

@jcvignoli Here we go https://github.com/php-stubs/wordpress-stubs/releases/tag/v6.7.2

[jcvignoli]

Thanks!

[IanDelMar]

v6.7.2

I think we're out of sync with core now.