Skip to content

Conversation

@mikeymike
Copy link
Member

  • Klien changed the case of output, this broke checks

This is a quick fix for the issue Klien introduced when it changed the case of it's output. I'd like to think of a different solution to prevent having to update the dependencies for minor increments but I'm not entirely convinced by my other solution atm. Something to discuss again one day, for now this should sort things out.

* Klien changed the case of output, this broke checks
@codecov-io
Copy link

codecov-io commented Dec 3, 2017

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #84   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         350    319   -31     
=====================================
- Hits          350    319   -31
Impacted Files Coverage Δ
src/Exercise/ArrayWeGo.php 100% <0%> (ø) ⬆️
src/Exercise/MyFirstIo.php 100% <0%> (ø) ⬆️
src/Exercise/BabySteps.php 100% <0%> (ø) ⬆️
src/Exercise/DependencyHeaven.php 100% <0%> (ø) ⬆️
src/Exercise/FilteredLs.php 100% <0%> (ø) ⬆️
src/Exercise/ExceptionalCoding.php 100% <0%> (ø) ⬆️
src/Exercise/TimeServer.php 100% <0%> (ø) ⬆️
src/Exercise/DatabaseRead.php 100% <0%> (ø) ⬆️
src/Exercise/ConcernedAboutSeparation.php 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d064f3...bbc47bb. Read the comment docs.

Copy link
Member

@AydinHassan AydinHassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AydinHassan AydinHassan merged commit 3f5e0cf into master Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants