frankenphp-symfony: call gc_collect_cycles() after handling request#142
Merged
alexander-schranz merged 1 commit intophp-runtime:mainfrom Oct 30, 2023
Merged
Conversation
alexander-schranz
approved these changes
Oct 26, 2023
Member
alexander-schranz
left a comment
alexander-schranz
left a comment
There was a problem hiding this comment.
Make sense, maybe we should do the same in other runtimes.
nicolas-grekas
approved these changes
Oct 27, 2023
dunglas
force-pushed
the
perf/frankenphp-gc_collect_cycles
branch
from
1a23d9e to
e08a151
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering the garbage collector after the request has been handled and when the worker may be idle prevents the garbage collection from being randomly done in the middle of the handling of a request (which delays the delivery of the HTTP response).
Another option, that is done by Laravel Octone, is to trigger the GC when a configurable amount of memory has been consumed instead of after every request.
I think this patch is good enough for FrankenPHP as usually many workers will be available.