Removed incorrect StreamOutput type hint#2
Merged
bachpedersen merged 1 commit intophp-riak:masterfrom Apr 11, 2014
Merged
Conversation
StreamOutput stub contained an incorrect type hint. I have removed it so it's compatible with the actual php_riak library. Before: public function receive(Output $response); Now: public function receive($response); The typehint in PHPDoc comment is still there so the IDE keeps hinting the Output methods for $response variable.
Contributor
|
Thanks for the pr 👍 |
bachpedersen
pushed a commit
that referenced
this pull request
Apr 11, 2014
Removed incorrect StreamOutput type hint
Author
|
It would seem to make more sense to actually change the php_riak itself, so it contains the type hint. Once that is done, we should change this back. However, changing php_riak requires some C knowledge I don't have, so I will probably not be able to do PR there. Just saying... And thanks for the merge! |
Contributor
|
Yea good point, I created an issue in php_riak just to remember it for next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamOutput stub contained an incorrect type hint. I have
removed it so it's compatible with the actual php_riak library.
Before: public function receive(Output $response);
Now: public function receive($response);
The typehint in PHPDoc comment is still there so the IDE
keeps hinting the Output methods for $response variable.