Skip to content

Implement faster FilteredRecursiveDirectoryIterator #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

staabm
Copy link

@staabm staabm commented Feb 25, 2023

closes #135

running parallel lint in https://github.com/FriendsOfREDAXO/rexstan with vendor/bin/parallel-lint . --exclude vendor takes 0.3 seconds with this PR while it took 9 seconds before the PR

@staabm staabm marked this pull request as ready for review February 25, 2023 22:58
@jrfnl jrfnl added this to the 2.0.0 milestone Mar 3, 2023
@staabm
Copy link
Author

staabm commented Mar 15, 2023

@jrfnl anything I can do to move this forward?

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 15, 2023

@staabm Not really. I'll try to find some time to review this over the next few weeks. That should hopefully help, but this is, in my experience, generally speaking a slow moving repo, so patience is the keyword...

@staabm
Copy link
Author

staabm commented Apr 2, 2023

Tbh I have implemented against 1.x - we need to verify it against 2.x (and see whether the speed improvements are still visible on 2.x)

@staabm
Copy link
Author

staabm commented Apr 9, 2023

let my clarify my last comment: the PR works in parallel-lint 1.x which I am currently using and it gives a decent speed boost, because without it, vendor files get linted even though I am passing --exclude vendor.

I did not verify the fix on parallel-int 2.x .. it looks like on 2.x the vendor is properly ignored even before this patch

@staabm
Copy link
Author

staabm commented Sep 20, 2024

@jrfnl we just talked about this :-)

(It might no longer be relevant)

fix cs

use ReturnTypeWillChange

Removed debug out

Typo
@staabm
Copy link
Author

staabm commented Sep 22, 2024

I can no longer reproduce the slownes in the latest 1.4.x release

@staabm staabm closed this Sep 22, 2024
@staabm staabm deleted the filtered-iterator branch September 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

parallel-lint iterates directory structure even if excluded
2 participants