Skip to content

Tests: move test fixtures to a "fixtures" subdirectory #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Mar 4, 2022

Test fixtures are "dummy" files to be used by the actual tests. These files will often contain parse errors and do not need to comply with code standards.

Let's make this very clear by moving the files to a dedicated fixtures subdirectory of tests, as examples could mislead people into thinking the directory contains examples of how to use PHP Parallel Lint.

Test fixtures are "dummy" files to be used by the actual tests. These files will often contain parse errors and do not need comply with code standards.

Let's make this very clear by moving the files to a dedicated `fixtures` subdirectory of tests, as `examples` could mislead people into thinking the directory contains examples of how to _use_ PHP Parallel Lint.
@jrfnl jrfnl added this to the 2.0.0 milestone Mar 4, 2022
@jrfnl jrfnl requested a review from grogy March 4, 2022 13:42
@grogy
Copy link
Member

grogy commented Mar 7, 2022

Thank you, merged 👍

@grogy grogy merged commit a01cf4c into develop Mar 7, 2022
@grogy grogy deleted the feature/tests-move-fixtures branch March 7, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants