Use PHP-Code-Style 2.0 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Composer: require `php-parallel-lint/php-code-style` at 2.0 or higher. * Composer: remove the requirement for PHPCS. This will now be inherited from the code style repo. * Composer: allow execution of the PHPCS Composer plugin, which is a dependency of the PHP Code Style repo. * GH Actions, test workflow: adjust the removal of the PHPCS dependency to match.
* Use the ruleset from PHP-Code-Style, but keep the custom property settings. * Set the `testVersion` for use with PHPCompatibility. * Improve the documentation in the ruleset.
... for things to be addressed at a later point in time and a few which don't need addressing at all.
Fix up the issues which will be flagged by PHP-Code-Style 2.0 and explicitly ignore a couple of (non-)issues.
grogy
approved these changes
Mar 3, 2022
|
I prefer fix incorrect code with changing ruleset, but it is my personal preference. Thank you, merged :-) |
|
@grogy Most issues flagged by the new ruleset have been fixed, I just excluded some which are more easily fixed in the "test refactor" project (and I have commits lined up to address all of those, except the cyclomatic complexity ones) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS: use PHP-Code-Style 2.0
php-parallel-lint/php-code-styleat 2.0 or higher.Ruleset: update for PHP-Code-Style 2.0
testVersionfor use with PHPCompatibility.Ruleset: add a few selective exclusions
... for things to be addressed at a later point in time and a few which don't need addressing at all.
CS: various minor fixes
Fix up the issues which will be flagged by PHP-Code-Style 2.0 and explicitly ignore a couple of (non-)issues.