Skip to content

Avoid calling getSerializableData() #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Avoid calling getSerializableData() #98

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2e469a1
WIP
SOHELAHMED7 Mar 10, 2025
7d0f71f
WIP 2
SOHELAHMED7 Mar 10, 2025
918f5bf
Handle nullable value
SOHELAHMED7 Mar 10, 2025
ae7bbfb
Change lot of tests
SOHELAHMED7 Mar 10, 2025
b80fcd6
Change lot of tests 2 - Fix failing tests
SOHELAHMED7 Mar 10, 2025
60779f6
Change lot of tests 3 - Fix failing tests
SOHELAHMED7 Mar 10, 2025
039af2b
Change lot of tests 4 - Fix failing tests + Add docs
SOHELAHMED7 Mar 11, 2025
f1bba1e
Change lot of tests 5 - Fix failing tests
SOHELAHMED7 Mar 11, 2025
6c55bf1
Merge branches 'master' and '81-avoid-calling-getserializabledata' of…
SOHELAHMED7 Mar 12, 2025
5e0b754
Fix failing test
SOHELAHMED7 Mar 12, 2025
633cfcc
Merge branches 'master' and '81-avoid-calling-getserializabledata' of…
SOHELAHMED7 Mar 12, 2025
9538035
Example usage for https://github.com/php-openapi/yii2-openapi/pull/98…
SOHELAHMED7 Mar 12, 2025
47e5e84
Revert "Example usage for https://github.com/php-openapi/yii2-openapi…
SOHELAHMED7 Mar 12, 2025
1341108
Merge branches 'master' and '81-avoid-calling-getserializabledata' of…
SOHELAHMED7 Mar 13, 2025
a543737
Update dependency
SOHELAHMED7 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP 2
  • Loading branch information
@SOHELAHMED7
SOHELAHMED7 committed Mar 10, 2025
commit 7d0f71fb8548089e0d59cce4b92c43cba2c5843b
16 changes: 10 additions & 6 deletions src/lib/AttributeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,12 @@ public function resolve(): DbModel
/** @var $property PropertySchema */

$isRequired = $this->componentSchema->isRequiredProperty($property->getName());
$nullableValue = $property->getProperty()->getSerializableData()->nullable ?? null;
if ($nullableValue === false) { // see docs in README regarding NOT NULL, required and nullable
$isRequired = true;
$nullableValue = false; # https://github.com/OAI/OpenAPI-Specification/blob/main/proposals/2019-10-31-Clarify-Nullable.md

if ($property->hasAttr('nullable')) {
if ($property->getAttr('nullable') === true) {
$nullableValue = true;
}
}

if ($this->isJunctionSchema) {
Expand Down Expand Up @@ -211,9 +214,10 @@ protected function resolveProperty(
$nullableValue = 'ARG_ABSENT'
): void {
if ($nullableValue === 'ARG_ABSENT') {
// $nullableValue = $property->getProperty()->getSerializableData()->nullable ?? null;
// $nullableValue = $property->getAttr('nullable') ?? null;
$nullableValue = $property->getProperty()->nullable ?? null;
$nullableValue = false;
if ($property->hasAttr('nullable') && $property->getAttr('nullable') === true) {
$nullableValue = true;
}
}
$attribute = Yii::createObject(Attribute::class, [$property->getName()]);

Expand Down
Loading