Skip to content

Conversation

@nadar
Copy link
Member

@nadar nadar commented Jun 18, 2022

the use of _exec() is not required, unless exec() is public.

@amouhzi what was the idea behind? Is there any instruction we should people give in the phpdocs when they use exec() directly?

the use of `_exec()` is not required, unless `exec()` is public.
@nadar nadar requested a review from amouhzi June 18, 2022 12:18
@nadar nadar self-assigned this Jun 18, 2022
@amouhzi amouhzi merged commit d0ba777 into master Jun 18, 2022
@amouhzi
Copy link
Member

amouhzi commented Jun 18, 2022

No idea, it's a very old project. Any improvement is welcome.

@nadar nadar deleted the exec branch July 29, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants