Skip to content

use false as default value for boolean #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions memcached-api.php
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,9 @@ public function getMulti( array $keys, $flags = 0) {}

public function getMultiByKey( $server_key, array $keys, $flags = 0) {}

public function getDelayed( array $keys, $with_cas = null, $value_cb = null ) {}
public function getDelayed( array $keys, $with_cas = false, $value_cb = null ) {}

public function getDelayedByKey( $server_key, array $keys, $with_cas = null, $value_cb = null ) {}
public function getDelayedByKey( $server_key, array $keys, $with_cas = false, $value_cb = null ) {}

public function fetch( ) {}

Expand Down
4 changes: 2 additions & 2 deletions php_memcached.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ public function get(string $key, callable $cache_cb=NULL, int $get_flags=0): mix
public function getByKey(string $server_key, string $key, callable $cache_cb=NULL, int $get_flags=0): mixed {}
public function getMulti(array $keys, int $get_flags=0): false|array {}
public function getMultiByKey(string $server_key, array $keys, int $get_flags=0): false|array {}
public function getDelayed(array $keys, bool $with_cas=NULL, callable $value_cb=NULL): bool {}
public function getDelayedByKey(string $server_key, array $keys, bool $with_cas=NULL, callable $value_cb=NULL): bool {}
public function getDelayed(array $keys, bool $with_cas=false, callable $value_cb=NULL): bool {}
public function getDelayedByKey(string $server_key, array $keys, bool $with_cas=false, callable $value_cb=NULL): bool {}
public function fetch(): false|array {}
public function fetchAll(): false|array {}

Expand Down
6 changes: 3 additions & 3 deletions php_memcached_arginfo.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 8ce11ff45ccb2b1c765e5f313305f539ca3fa4f6 */
* Stub hash: a37775073c8863c1a4e4ea280a103beaacdf7305 */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Memcached___construct, 0, 0, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, persistent_id, IS_STRING, 0, "NULL")
Expand Down Expand Up @@ -39,14 +39,14 @@ ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Memcached_getDelayed, 0, 1, _IS_BOOL, 0)
ZEND_ARG_TYPE_INFO(0, keys, IS_ARRAY, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, with_cas, _IS_BOOL, 0, "NULL")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, with_cas, _IS_BOOL, 0, "false")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, value_cb, IS_CALLABLE, 0, "NULL")
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Memcached_getDelayedByKey, 0, 2, _IS_BOOL, 0)
ZEND_ARG_TYPE_INFO(0, server_key, IS_STRING, 0)
ZEND_ARG_TYPE_INFO(0, keys, IS_ARRAY, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, with_cas, _IS_BOOL, 0, "NULL")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, with_cas, _IS_BOOL, 0, "false")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, value_cb, IS_CALLABLE, 0, "NULL")
ZEND_END_ARG_INFO()

Expand Down
2 changes: 1 addition & 1 deletion php_memcached_legacy_arginfo.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 8ce11ff45ccb2b1c765e5f313305f539ca3fa4f6 */
* Stub hash: a37775073c8863c1a4e4ea280a103beaacdf7305 */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Memcached___construct, 0, 0, 0)
ZEND_ARG_INFO(0, persistent_id)
Expand Down