fix php8 arginfo #467
Merged
fix php8 arginfo #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@remicollet Please review as you added the most recent iteration of these stub files. |
remicollet
reviewed
Dec 1, 2020
| public function append(string $key, string $value): ?bool {} | ||
| public function appendByKey(string $server_key, string $key, string $value): ?bool {} | ||
| public function prepend(string $key, string $value): ?bool {} | ||
| public function prependByKey(string $server_key, string $key, string $value): ?bool {} |
There was a problem hiding this comment.
From php_memc_store_impl these methods return NULL on error (cannot append/prepend with compression turned on) so another way is to raise an exception (PHP 8 only) in such case, as part of the "promote error to exception" global change.
|
Thanks! Merging now. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes for stub/arginfo to match the reality, which makes the test suite complete successfully on PHP-8.0