Include a fuller list of response constants from libmemcached #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I ran into a case where I was getting an error code
3
due to misconfiguration, which didn't map to any known error type in the PHP library. This led me to find https://bazaar.launchpad.net/~tangent-trunk/libmemcached/1.0/view/head:/libmemcached-1.0/types/return.h, and as far as I know, this should have been aMEMCACHED_CONNECTION_FAILURE
. When I looked around, I noticed we were missing quite a few return types in php-land. I tried to find the ones that were absent and slot them in, and also worked to improve the ordering of most of them by redefining them in the order they were defined inreturn.h
.Things I don't know: Is this compatible with all supported libmemcached versions? How could I find out? I'm not super familiar with c level stuff, so bear with me here if you can!