Fix tests for PHP 7.1 #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invoke_callback_2 fails because of ArgumentCountException (init_cb_arg gets only 2 args). Check number of passed arguments with func_num_args() insteadof checking $args is null session_lock fails because of second warning in 7.1 Skip session_lock.phpt for php < 7.1 and create new testcase for >= 7.1 which tests both warnings.
Fix expected warning
- fix whitespace. Now configured TAB for phpt files too...
SjonHortensius
approved these changes
Jan 20, 2017
| @@ -18,9 +18,9 @@ function init_cb_fail($m, $id) { | |||
| echo "configured, should not be called.\n"; | |||
| } | |||
|
|
|||
| function init_cb_arg($m, $id, $arg) { | |||
| function init_cb_arg($m, $id) { | |||
| var_dump(func_num_args()); | |||
update .travis.yml, don't allow failures for 7.1 anymore.
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke_callback_2 fails because of ArgumentCountException (init_cb_arg gets only 2 args).
Check number of passed arguments with func_num_args() insteadof checking $args is null
session_lock fails because of second warning in 7.1
Skip session_lock.phpt for php < 7.1 and create new testcase for >= 7.1 which tests both warnings.