Adjust the Travis CI matrix: PHP 7.0 and 7.1, fewer revisions of libmemcached#273
Conversation
|
I actually don't know if the PHP 7 branch is capable of working with PHP 5.5 or 5.6. My hope would be to have a single php-memcached master branch and next release that works across the three supported revisions. Let's see how it goes. |
|
With PHP < 7.0 |
|
The php7 branch targets php7 only. It won't compile under any version of php5. If they are planning to have a master branch that targets master and php7, it is possible two ways (But they probably wouldn't do that until php7 was stable):
|
|
I think the sane path forward is:
|
.travis.yml
Outdated
| - LIBMEMCACHED_VERSION=1.0.18 # Debian Jessie / Ubuntu Xenial | ||
| - LIBMEMCACHED_VERSION=1.0.16 # RHEL / CentOS 7 | ||
| - LIBMEMCACHED_VERSION=1.0.8 # Debian Wheezy / Ubuntu Trusty | ||
| - LIBMEMCACHED_VERSION=0.44 # Ubuntu Precise |
There was a problem hiding this comment.
Is Precise still relevant for 3.0 (php7) code base? If it's not meant to be supported, and given tests fails with it, I wouldn't re-add it here.
|
PHP 7.1 compat for msgpack blocked on msgpack/msgpack-php#100 |
d7b5a53 to
82d8ee7
Compare
|
@laruence Ideally a fix for msgpack/msgpack-php#100 will land first so that I can remove my personal branch from this PR, if you have time could you merge msgpack/msgpack-php#104? |
a659ad1 to
1c06e21
Compare
No description provided.