test: compression edge case verification

[dictcp]

• follow-up of fix: compression edge case #255
• will test compressed SET/GET under various setting of
  • compression_factor
  • compression_threshold
  • data length
• in any case, the the result of GET should be the same as what is SET
  • and free from any memory allocation issue
• it should work after fix: compression edge case #255 is merged
  • eg. https://travis-ci.org/dictcp/php-memcached/builds/136763933

[sodabrew]

The tests fail with this error:

016+ Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 1701998440 bytes) in /tmp/php-memcached-build/memcached-3.0.0a1/tests/compression_conditions.php on line 41

The allowed memory size is a PHP config item. The test file could try adding this code to raise the limit:

    ini_set('memory_limit', '200M');

If you have time to revisit this code, please also rebase to master branch since php7 has merged (just as on #255 as well).

[dictcp]

@sodabrew it should work after #255 is merged. and the memory allocation issue is due to the previous (incorrect) logic on compression flag handling

[sodabrew]

Now that #255 is landed could you rebase this so we can confirm that tests pass?

[sodabrew]

========DIFF========
009+ bool(false)
009- bool(true)
022+ bool(false)
022- bool(true)
========DONE========
FAIL Memcached compression test [tests/compression_conditions.phpt] 

[sodabrew]

I think the failures are this one (bool on line 9)

Expected:
 len=[7] set=[zlib] factor=[1.3] threshold=[4]
 Memcached::set(): could not compress value
 bool(true)
Actual:
 len=[7] set=[zlib] factor=[1.3] threshold=[4]
 Memcached::set(): could not compress value
 bool(false)

And this one (bool on line 22)

Expected:
 len=[7] set=[zlib] factor=[0.3] threshold=[4]
 Memcached::set(): could not compress value
 bool(true)
Actual:
 len=[7] set=[zlib] factor=[0.3] threshold=[4]
 Memcached::set(): could not compress value
 bool(false)

In both cases the false corresponds with an expected error. Wouldn't it make sense to expect false to go along with that error?

[sodabrew]

Oh, oh I see - the false indicates that the value did not round-trip correctly through memcached:

       $m->set($key, $value, 1800);
       $value_back = $m->get($key);
       var_dump($value === $value_back);

[sodabrew]

I don't really see the point for this block of code:

        if (!compress_status) {
                php_error_docref(NULL, E_WARNING, "could not compress value");
                efree (buffer);
                return 0;
        }

If the value was not compressed, then it won't be flagged as compressed, and so it'll go into memcached uncompressed. I see no problem with that.

[sodabrew]

Merged to master as 7283b11

[dictcp]

thanks @sodabrew. my bad on overlooking during rebase.