Fix compression on big-endian architecture #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On big-endian architecture where size_t is a 64-bit long, copying the 4 first bytes as the size is incorrect. We cast it to an unsigned 32-bit integer before copying it at the beginning of the provided buffer.
mkoppanen
pushed a commit
that referenced
this pull request
Jan 9, 2014
Fix compression on big-endian architecture
|
Looking at this I guess ideally storing network ordered and converting to host byte order on receive would make most change (but also break backwards compatibility). |
|
I don't think it is worth it. |
|
I opened a pull, which fixes the issue in a backwards compatible manner. Haven't merged yet because not sure if it's worth it (in practice x86/x86-64 will be used by the majority). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On big-endian architecture where size_t is a 64-bit long,
copying the 4 first bytes as the size is incorrect. We cast it to an
unsigned 32-bit integer before copying it at the beginning of the
provided buffer.