This repository was archived by the owner on Jul 16, 2025. It is now read-only.
refactor: introduce decoupled platform layer and convert models to state objects #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
commented
Oct 13, 2024
chr-hertel
force-pushed
the
refactor-platform-layer
branch
2 times, most recently
from
ee5f92d to
ef7f3e0
Compare
chr-hertel
force-pushed
the
refactor-platform-layer
branch
from
ef7f3e0 to
84f0546
Compare
chr-hertel
force-pushed
the
refactor-platform-layer
branch
from
84f0546 to
57262da
Compare
Contributor
|
Sorry for being not so active, I am a little bit busy right now. |
Member
Author
|
@OskarStark no worries at all Oskar - i'm currently finishing up those 4 MRs and will try them in my demo app with the bundle to get them merged 👍 |
Contributor
|
Thanks, if my response format is working for tools, I could also switch entirely to our bundle/lib |
chr-hertel
force-pushed
the
refactor-platform-layer
branch
3 times, most recently
from
f2a2d57 to
91ec520
Compare
chr-hertel
force-pushed
the
feat-replicate-llama
branch
from
8f87f8b to
71e7916
Compare
chr-hertel
force-pushed
the
refactor-platform-layer
branch
from
91ec520 to
31a28d9
Compare
chr-hertel
force-pushed
the
refactor-platform-layer
branch
from
31a28d9 to
56deee0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR focusses on shaping the model and platform concept.
ResponseFactoryandResponseConverter=> decoupling => way better testabilityOnly thing missing right now is fixing embedding by bringing support for parallel calls on Platform back
best to review in IDE