Added option to optimize primitive schemas before exporting them to a file #19
Conversation
|
I believe it should be possible to do this with the new optimizer way in a separate optimizer, which would be prefered, to not clutter the main class more ✌️ |
src/Optimizer/AbstractOptimizer.php
Outdated
| * @param array|mixed $data | ||
| * @return bool | ||
| */ | ||
| protected function isPrimitive($data): bool |
There was a problem hiding this comment.
I think the better solution would be to enhance SchemaTemplate::isPrimitve and pass it as optional argument to optimize (would not need Interface adjustment -> no break)
There was a problem hiding this comment.
as mentioned above, you can probably kill this func now and just pass $resolvedTemplate->isPrimitive() to optimize in the merger ✌️
src/Optimizer/AbstractOptimizer.php
Outdated
| * @param array|mixed $data | ||
| * @return bool | ||
| */ | ||
| protected function isPrimitive($data): bool |
There was a problem hiding this comment.
as mentioned above, you can probably kill this func now and just pass $resolvedTemplate->isPrimitive() to optimize in the merger ✌️
|
@bajdzun lgtm, thx for the addition 🙏 |
2 participants
Schema registry supports two ways of defining primitive schemas:
{"type": "string"}and:
"string"Which are equivalent according to Avro specification.
So, I added option to enable that behaviour by passing
--optimizePrimitiveSchemasoption.