use a PHPUnit bridge version that is compatible with recent PHPUnit releases #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 4, 2023
•
xabbuh
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| Documentation | |
| License | MIT |
xabbuh
changed the title
dbu
reviewed
Dec 5, 2023
There was a problem hiding this comment.
thanks for looking into this.
the phpstan error is our friend from php-http/client-common#234 (comment) - not related to your changes.
can you maybe check the flex composer plugin error? maybe we just never built this package since composer started having configuration to control plugin execution and we need to allow the flex plugin.
|
I fixed the Flex error in my PR, if you merge this I can merge it into mine and it should be good I think |
xabbuh
force-pushed
the
phpunit-bridge
branch
from
a7548b7
to
01718c1
Compare
|
thank you! merged in #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.