Add support for PHPUnit10 and remove support for PHPUnit8 #60
Conversation
|
To avoid BC break:
|
There was a problem hiding this comment.
thanks a lot! i added some nitpicks.
@Nyholm @weierophinney do you have a way to check if there are any regressions with the php http clients using these integration tests? looking at the CI of this repository, i see that it only provides the tests but does not run them.
|
i fixed the ci to run the tests. and we meanwhile completely removed the references to obsolete zend diactoros in favor of laminas. can you please rebase on the current master branch and solve the conflicts? |
i would be in favor of raising phpunit 9 to 9.5 to allow upgrading the configuration file to the new format. |
|
ping @nyamsprod do you want to try upgrading the configuration file? and please rebase on the master branch to solve the conflicts |
|
@dbu sorry for the late reply I was overloaded by work all week .. will do the proper fix this weekend |
|
great, thanks! no worries, in OSS we do what we can, the job and health and family all take priority before OSS |
|
@dbu did update the PR in regard to your latest comments. Hopes everything is fine now |
| @@ -13,3 +13,4 @@ | |||
| /phpunit.xml.dist export-ignore | |||
| /spec/ export-ignore | |||
| /tests/ export-ignore | |||
| /.phpunit.cache/ export-ignore | |||
There was a problem hiding this comment.
| /.phpunit.cache/ export-ignore |
this is not committed and should not. .gitattributes tells github what to exclude when downloading the zip of a repository. we instead want tot add this in .gitignore
| "psr/http-message": "^1.0 || ^2.0" | ||
| "php": "^7.3 || ^8.0", | ||
| "phpunit/phpunit": "^9.3 || ^10.0", | ||
| "psr/http-message": "^1.0" |
There was a problem hiding this comment.
| "psr/http-message": "^1.0" | |
| "psr/http-message": "^1.0 || ^2.0" |
we should keep allowing http-message 2.0. i think this was one of the merge conflicts.
src/BaseTest.php
Outdated
| return $factory->createUri($uri); | ||
| } | ||
| if ($factory instanceof \Psr\Http\Message\UriFactoryInterface) { | ||
| if ($uri instanceof UriInterface) { | ||
| if ($factory instanceof PsrUriFactoryInterface) { |
thanks for your work. i think that some test suites do not fail means the |
|
note that some implementations will have some tests failing - I will compare those with the 1.x branch to see if there are any differences. |
|
@dbu any update on this PR ? Do I still need to do something ? |
What's in this PR?
To Do