Add Fulfilled and Rejected promise implementations #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelwurtz do you think this will have any bad effect? |
| @@ -75,7 +75,7 @@ $ git rebase -i HEAD~3 | |||
| If your branch conflicts with the master branch, you will need to rebase and repush it with the following commands: | |||
|
|
|||
| ``` bash | |||
| $ git remote add upstream git@github.com:php-http/repo-name.git | |||
| $ git remote add upstream git@github.com:orga/repo-name.git | |||
There was a problem hiding this comment.
change to php-http/promise? otherwise we can just link to a global contributing guide instead of committing the same file in every repo.
There was a problem hiding this comment.
My idea was to use the same everywhere.
There was a problem hiding this comment.
No hassle with updating the differences.
There was a problem hiding this comment.
but then we could also have a file with just a link to a wiki page in
httplug, or a documentation page on httplug.io. then we would not need
to keep the file in sync.
on the other hand, that file is not likely to change often. i don't mind
either way.
There was a problem hiding this comment.
Low prio IMO, moved to php-http/documentation#44. For now it is just easier to copy files from boilerplate without thinking. 😛
|
Merging this and tagging a PATCH release so we can actually use it. I don't think it could cause any problem. |
sagikazarmark
added a commit
that referenced
this pull request
Dec 24, 2015
Add Fulfilled and Rejected promise implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the idea from php-http/httplug#98.
One major change: Promise now handles \Exception instead of HttplugException.
Reasoning: avoiding circular dependency, moving towards the PSR which will definitely not use our exception interfaces.