Skip to content

Commit

Permalink
cleanup promise phpdoc
Browse files Browse the repository at this point in the history
  • Loading branch information
dbu committed Jan 4, 2024
1 parent 625ad74 commit 1605264
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 22 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@v3

- name: Remove phpspec
run: composer remove --dev friends-of-phpspec/phpspec-code-coverage phpspec/phpspec

- name: PHPStan
uses: docker://oskarstark/phpstan-ga
with:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
],
"require": {
"php": "^7.1 || ^8.0",
"php-http/promise": "^1.1",
"php-http/promise": "dev-phpdoc-revert as 1.3.0",
"psr/http-client": "^1.0",
"psr/http-message": "^1.0 || ^2.0"
},
Expand Down
3 changes: 0 additions & 3 deletions src/Exception/RequestAwareTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ private function setRequest(RequestInterface $request)
$this->request = $request;
}

/**
* {@inheritdoc}
*/
public function getRequest(): RequestInterface
{
return $this->request;
Expand Down
9 changes: 0 additions & 9 deletions src/Promise/HttpFulfilledPromise.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ public function __construct(ResponseInterface $response)
$this->response = $response;
}

/**
* {@inheritdoc}
*/
public function then(callable $onFulfilled = null, callable $onRejected = null)
{
if (null === $onFulfilled) {
Expand All @@ -34,17 +31,11 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
}
}

/**
* {@inheritdoc}
*/
public function getState()
{
return Promise::FULFILLED;
}

/**
* {@inheritdoc}
*/
public function wait($unwrap = true)
{
if ($unwrap) {
Expand Down
9 changes: 0 additions & 9 deletions src/Promise/HttpRejectedPromise.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ public function __construct(Exception $exception)
$this->exception = $exception;
}

/**
* {@inheritdoc}
*/
public function then(callable $onFulfilled = null, callable $onRejected = null)
{
if (null === $onRejected) {
Expand All @@ -38,17 +35,11 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
}
}

/**
* {@inheritdoc}
*/
public function getState()
{
return Promise::REJECTED;
}

/**
* {@inheritdoc}
*/
public function wait($unwrap = true)
{
if ($unwrap) {
Expand Down

0 comments on commit 1605264

Please sign in to comment.