Skip to content

1.10.1 release #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

1.10.1 release #187

wants to merge 1 commit into from

Conversation

joelwurtz
Copy link
Member

Ok to release ?

dbu
dbu approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am a bit worried by the phpspec failure but it seems to be about some change with phpspec in version 8 and not about our code.

i am ok with releasing as is. if somebody has time to fix the phpspec 8 build, it would be cool, but can be done after the release too.

@GrahamCampbell
Copy link
Contributor

Should be a 1.11.0, since a new deprecation cannot be in a patch release?

@joelwurtz joelwurtz mentioned this pull request Sep 22, 2020
Merged
@joelwurtz
Copy link
Member Author

fixed in #188

@joelwurtz joelwurtz closed this Sep 22, 2020
@nicolas-grekas nicolas-grekas deleted the joelwurtz-patch-1 branch February 10, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelwurtz @GrahamCampbell @dbu