Skip to content

Use laminas/laminas-diactoros package #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2020
Merged

Use laminas/laminas-diactoros package #67

merged 2 commits into from
Jan 6, 2020

Conversation

jxlwqq
Copy link
Contributor

@jxlwqq jxlwqq commented Jan 3, 2020 •
edited by sagikazarmark
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #66
License MIT

What's in this PR?

Use laminas/laminas-diactoros package.

@sagikazarmark sagikazarmark requested review from Nyholm and dbu January 3, 2020 12:23
@Nyholm
Copy link
Member

Nyholm commented Jan 3, 2020

Thank you.
Dont we need to update some use statements too?
Or was this package only used to enable auto discovery?

dbu
dbu requested changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i grep the tests, we do explicitly instantiate things with the Zend\Diactoros namespace. those need to be adjusted i think.

there are a lot of skipped tests in travis-ci, maybe we did something to skip tests if zend is not available.

@jxlwqq jxlwqq changed the title Update composer.json Use laminas/laminas-diactoros package Jan 6, 2020
@jxlwqq jxlwqq requested a review from dbu January 6, 2020 09:49
dbu
dbu approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit 8ecd117 into php-http:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package zendframework/zend-diactoros is abandoned
3 participants
@jxlwqq @Nyholm @dbu