Add functions to convert between WGS-84 and OSGB36 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 9, 2012 22:27
* converts from cartesian to polar based on Airy 1830 * need to handle different ellipsoids
* transform caresian to polar co-ords * clean up code of helmert a lot * by combining output can transform between datums * -1 error with height * next step is to move these php functuons to C functions and create convert datum PHP function and wrappers
* more tests
|
Looks good, though if I'm being really fussy the whitespace seems to be a bit different to how the rest of the file is? Can you be bothered fixing that? |
|
Yep yep I'll fix it up and add another commit |
* more comments
|
Hopefully that has fixed the whitespace issues |
* add test for decimal minutes * add test on prime meridian based on this photo http://upload.wikimedia.org/wikipedia/commons/a/a1/Garmin_GPS_at_Greenwich_Observatory.jpg
|
Oops, I'd not seen that notification. Any reason you closed it? I'm happy to merge it after I test it later today. |
|
I was just going to open again from a different branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using my rudimentary knowledge of C I have implemented the helmert transformation and some other functions to make it useful.
This may be completely the wrong way to do it and I am happy to change any of it but just thought it would be good to get the functions in there.
I based the calculations on the spreadsheet www.ordnancesurvey.co.uk/oswebsite/gps/docs/ProjectionandTransformationCalculations.xls which seemed to be a pretty accurate source.