Skip to content

Refactor ColumnSchema::class in MSSQL, MySQL, Oracle, PostgreSQL. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

terabytesoftw
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #57

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 89.01734% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.79%. Comparing base (9694dcd) to head (0b1bff7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/db/ColumnSchema.php 74.54% 14 Missing ⚠️
src/db/mssql/ColumnSchema.php 89.47% 2 Missing ⚠️
src/db/mysql/ColumnSchema.php 94.73% 1 Missing ⚠️
src/db/oci/ColumnSchema.php 94.11% 1 Missing ⚠️
src/db/pgsql/ColumnSchema.php 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #111      +/-   ##
============================================
- Coverage     66.81%   66.79%   -0.02%     
+ Complexity    11209    11195      -14     
============================================
  Files           434      435       +1     
  Lines         36536    36546      +10     
============================================
+ Hits          24410    24411       +1     
- Misses        12126    12135       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw merged commit 137b0a7 into main Oct 13, 2024
92 checks passed
@terabytesoftw terabytesoftw added the Severity: BC breaking Either breaks backwards compatibility or fixed previously made breakage label Oct 13, 2024
@terabytesoftw terabytesoftw added this to the 1.0.0 milestone Oct 13, 2024
@terabytesoftw terabytesoftw deleted the refactor-column-schema branch October 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: BC breaking Either breaks backwards compatibility or fixed previously made breakage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant