Skip to content

Add method chaining style specification #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Add method chaining style specification #16

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29daead
Add method chaining style specification
vjik May 23, 2022
8d68bb4
Update spec.md
samdark Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,16 @@ $app->get('/hello/{name}', function ($name) use ($app) {
});
```

Method chaining SHOULD be put on separate lines, where each subsequent line is indented once. When doing so, the first
method MUST be on the next line.

```php
$someInstance
->create()
->prepare()
->run();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing ; on a separated line is handy as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xepozz I don't like the single ; in a new line.
I saw some people doing it, but because they were adding new lines right after that.

$someInstance
    ->create()
    ->prepare()
    ->run()
;
$anotherInstance->run()

My suggestion is to leave a blank space:

$someInstance
    ->create()
    ->prepare()
    ->run();

$anotherInstance->run()

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a little handy to comment/move/remove lines when you have ; not at the end of the chain, but I think it's unnecessary to have it as a recommendation :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my opinion it is best to admit both versions :)

```

## 5. Control Structures

The general style rules for control structures are as follows:
Expand Down