Refactor Dependencies::process() with exceptions

[siwinski]

No description provided.

[siwinski]

For the change here, I was trying to make this block of code use the same conditionals logic as Fedora\Autoloader::requireFile() without copying-and-pasting the conditionals. This does have the overhead of an Exception object creation (from Fedora\Autoloader::requireFile()) and the catch though. Perhaps a copy-and-paste of the conditionals here would be better or a common function (something like Fedora\Autoloader::fileLoadable()?) that this code block and Fedora\Autoloader::requireFile() could both use?

[remicollet]

no problem for me, feel free to merge for 0.2.0 is you want

[remicollet]

A boolean can be enough ?

[siwinski]

Yes! Updated.

[remicollet]

for consistency with other exception use single quote around each name.

[siwinski]

Updated.

[siwinski]

Updated

On Wed, Oct 26, 2016 at 1:51 AM, Remi Collet notifications@github.com
wrote:

@remicollet approved this pull request.

no problem for me, feel free to merge for 0.2.0 is you want

In src/Dependencies.php
#9 (review)
:

  */
 protected static function process(array $dependencies, $required)
 {
     foreach ($dependencies as $dependency) {
         if (is_array($dependency)) {

•            $dependencyToLoad = null;
  

•            $loadedDependency = null;
  

A boolean can be enough ?

In src/Dependencies.php
#9 (review)
:

                 }
             }

•            if ($required || isset($dependencyToLoad)) {
  

•                if (!isset($dependencyToLoad)) {
  

•                    $dependencyToLoad = end($dependency);
  

- }

•                requireFile($dependencyToLoad);
  

•            if ($required && empty($loadedDependency)) {
  

•                throw new \RuntimeException(sprintf(
  

•                  'Files not found: "%s"',
  

for consistency with other exception use single quote around each name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_HKNcLny1ROFKeCOUtLT0Nt7x8HsSQks5q3up1gaJpZM4Kgtjd
.