allow non full patch in dependencies list, rely on include_path #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siwinski
reviewed
Mar 12, 2017
There was a problem hiding this comment.
@remicollet Please review the comment regarding path matching in src/functions.php.
| /* Windows */ | ||
| if (ctype_alpha($path[0]) && $path[1]==':') { | ||
| return true; // Drive | ||
| } |
There was a problem hiding this comment.
Shouldn't this be?:
if (($path[0] == '/' && $path[1] == '/') || ($path[0] == '\\' && $path[1] == '\\')) {Or are paths like /\ and \/ valid?
There was a problem hiding this comment.
indeed, fixed (+ rebased)
remicollet
force-pushed
the
issue-incpath
branch
from
e22cb02 to
6216bf7
Compare
siwinski
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While full path is the recommended way, this could be used in case include_path should be used (PHPUnit and its dependencies)