[wip] Azure support #645
[wip] Azure support #645
Conversation
|
@sylfabre there are some conflicts. could you fix them, please? |
|
@makasim my colleague @PaulRouss3l is working on it now. He'll do it tomorrow. |
|
add a transport doc just like https://github.com/php-enqueue/enqueue-dev/blob/master/docs/transport/redis.md |
|
It needs more tests, at least spec tests should be implemented |
| { | ||
| InvalidMessageException::assertMessageInstanceOf($message, AzureStorageMessage::class); | ||
|
|
||
| if(false === $requeue) { |
There was a problem hiding this comment.
it should publish a message on requeue == true
| */ | ||
| public function setDeliveryDelay(int $deliveryDelay = null): Producer | ||
| { | ||
| throw new DeliveryDelayNotSupportedException(); |
There was a problem hiding this comment.
Do not throw exception if null is passed
| */ | ||
| public function setPriority(int $priority = null): Producer | ||
| { | ||
| throw new PriorityNotSupportedException(); |
There was a problem hiding this comment.
Do not throw exception if null is passed
|
Code styles should be fixed, you could run php-cs-fixer to auto-fix them. |
|
root phpunit.xml.dist file should be updated too, so tests are executed by travis. |
|
I'm currently implementing the tests, and will update with the comment you made above =) |
|
still wip |
| @@ -91,8 +91,7 @@ public function reject(Message $message, bool $requeue = false): void | |||
| InvalidMessageException::assertMessageInstanceOf($message, AzureStorageMessage::class); | |||
|
|
|||
| if (true === $requeue) { | |||
| $factory = new AzureStorageConnectionFactory($this->client); | |||
| $context = $factory->getContext(); | |||
| $context = new AzureStorageContext($this->client); | |||
There was a problem hiding this comment.
I think context should be passed in consumer constructor. The context should have a getClient public method
|
That was decided to release it as a stand-alone package https://github.com/assoconnect/enqueue-azure Closing PR. Thank you guys for your effort! |
No description provided.