DBAL Transport #54
Merged
DBAL Transport #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
Apr 19, 2017
pkg/dbal/DbalConnectionFactory.php
Outdated
| */ | ||
| private function establishConnection() | ||
| { | ||
| return $this->registry->getConnection($this->config['connectionName']); |
There was a problem hiding this comment.
I guess we should call connect at this stage
pkg/dbal/DbalConsumer.php
Outdated
| } catch (\LogicException $e) { | ||
| $this->dbal->rollBack(); | ||
| throw $e; | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
why do you need two catch statements here?
pkg/dbal/DbalConsumer.php
Outdated
| $message->setId($dbalMessage['id']); | ||
| $message->setBody($dbalMessage['body']); | ||
| $message->setPriority((int) $dbalMessage['priority']); | ||
| $message->setRedelivered((bool) $dbalMessage['redelivered']); |
bendavies
reviewed
Apr 20, 2017
| { | ||
| $builder | ||
| ->children() | ||
| ->scalarNode('connectionName') |
There was a problem hiding this comment.
other transport factories use snake_case
|
partly address #32 |
pkg/enqueue-bundle/Tests/Unit/EnqueueBundleTest.php
makasim
reviewed
Apr 21, 2017
| $clientMessage->setMessageId($message->getMessageId()); | ||
| $clientMessage->setTimestamp($message->getTimestamp()); | ||
| $clientMessage->setPriority(MessagePriority::NORMAL); | ||
| $clientMessage->setDelay($message->getDelay()); |
| $transportMessage->setProperties($properties); | ||
| $transportMessage->setMessageId($message->getMessageId()); | ||
| $transportMessage->setTimestamp($message->getTimestamp()); | ||
| $transportMessage->setDelay($message->getDelay()); |
pkg/dbal/Client/DbalDriver.php
Outdated
| throw new \LogicException('Topic name parameter is required but is not set'); | ||
| } | ||
|
|
||
| $topic = $this->createRouterTopic(); |
There was a problem hiding this comment.
better to use
$queue = $this->createQueue($this->config->getRouterQueueName());
| * | ||
| * @return DbalMessage|null | ||
| */ | ||
| public function receive($timeout = 0) |
There was a problem hiding this comment.
timeout in miliseconds, if you need seconds do $timeout / 1000
pkg/dbal/LICENSE
Outdated
| @@ -0,0 +1,20 @@ | |||
| The MIT License (MIT) | |||
| Copyright (c) 2016 Kotliar Maksym | |||
| { | ||
| new DbalDriver( | ||
| $this->createPsrContextMock(), | ||
| new Config('', '', '', '', '', '') |
pkg/dbal/composer.json
Outdated
| "name": "enqueue/dbal", | ||
| "type": "library", | ||
| "description": "Message Queue Doctrine DBAL Transport", | ||
| "keywords": ["messaging", "queue", "dbal"], |
|
LGTM, you can start with SQS. I'll take care of the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.